Remove examples/multi_gpu since all deprecated, point to CuGraph #10489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puririshi98
requested review from
akihironitta,
rusty1s and
wsad1
as code owners
…ople building on this and deleting the examples is easiest wayto avoid that
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
@akihironitta @rusty1s @wsad1 ready for merge |
Member
There was a problem hiding this comment.
@puririshi98 Mind doing a favor before merging this PR?
- List all the up-to-date cuGraph examples in the PR description so that we can guide PyG users to the up-to-date examples?
- Make sure there're no reference in the codebase or docs to these examples being deleted.
@alexbarghi-nv @puririshi98 Are there any considerations/implications of using cuGraph? It seems performant, but for example, I wonder how hard it'd be for users to try cuGraph because real use cases usually have many other (old) dependencies that may conflict with cuGraph's dependencies (, which was my experience with cudf in the past). Because of that, I'm slightly in favor of keeping these pure PyTorch examples as they are.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples/multi_gpu folder is stale. The data parallel examples are all stale in lieu of new updates from cugraph making a single unified api that handles any scale of compute seamlessly. (single gpu, single node multigpu, and multinode multigpu)
It is too much effort to mantain mirrored cugraph examples in pyg when we can just point directly to the cugraph examples. @alexbarghi-nv to review.
Model parralel is best recommended through PyT as opposed to mantaining our own third party examples
https://github.com/rapidsai/cugraph-gnn/tree/branch-25.12/python/cugraph-pyg/cugraph_pyg/examples